Skip to content

Align categories #15801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trisch-me merged 6 commits into from
Nov 19, 2025
Merged

Align categories #15801

trisch-me merged 6 commits into from
Nov 19, 2025

Conversation

@trisch-me
Copy link
Contributor

@trisch-me trisch-me commented Oct 29, 2025

This PR aligns categories from data_streams in templates with global categories of the integration.

Proposed commit message

Aligning categories of sub datastreams with category of integration itself.

Issues:
was discussed in https://github.com/elastic/protections-cloud/issues/15713

@jsoriano @JDKurma FYI

@trisch-me trisch-me requested review from a team as code owners October 29, 2025 16:32
@andrewkroh andrewkroh added Integration:aws AWS Integration:azure_metrics Azure Resource Metrics Integration:cloud_asset_inventory Cloud Asset Discovery Integration:cloud_security_posture Security Posture Management Integration:gcp Google Cloud Platform Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Oct 29, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 30, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@trisch-me
Copy link
Contributor Author

trisch-me commented Nov 5, 2025

@elastic/security-service-integrations @elastic/obs-ds-hosted-services @elastic/obs-infraobs-integrations could you please look into it?

andrewkroh
andrewkroh approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For each policy template category, I determined its parent category (or considered it its own parent if it wasn't a subcategory). Then, I validated that these derived parent categories were all present in the integration package's categories. Then I checked that the parent categories of policy template categories are a subset of package categories. I checked all integrations present in 5245547.

The category relationships I used are given in https://github.com/elastic/package-registry/blob/1bec8bf2e7f67f04f38a6310f5b70e56e3b22bfd/categories/categories.yml

@andrewkroh
Copy link
Member

andrewkroh commented Nov 12, 2025 •
edited
Loading

I think proposed commit message could use a deeper explanation. And we should refer to "policy template" instead of "datastreams". Suggestion:

This commit addresses inconsistencies in package categorization by adding
missing categories to various integration packages.

Previously, policy templates within certain integrations used categories
(or their parent categories) that were not explicitly defined at the
integration level. This was identified by ensuring all parent categories
of policy template categories are a subset of integration-level
categories.

References

https://github.com/elastic/package-registry/blob/1bec8bf2e7f67f04f38a6310f5b70e56e3b22bfd/categories/categories.yml

That doesn't answer the why behind this change so you should add that.

@trisch-me trisch-me requested a review from a team as a code owner November 18, 2025 13:34
@trisch-me
Copy link
Contributor Author

trisch-me commented Nov 18, 2025

@uri-weisman could you please check this PR as a maintainer of @elastic/contextual-security

uri-weisman
uri-weisman approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@uri-weisman uri-weisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Nov 18, 2025

💚 Build Succeeded

History

@trisch-me trisch-me merged commit 221f106 into elastic:main Nov 19, 2025
6 checks passed
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
@trisch-me
align categrories of data_streams with generic intergation category (e…
14014a9 
…lastic#15801)

This commit addresses inconsistencies in package categorization by adding
missing categories to various integration packages.

Previously, policy templates within certain integrations used categories
(or their parent categories) that were not explicitly defined at the
integration level. This was identified by ensuring all parent categories
of policy template categories are a subset of integration-level
categories.

References

https://github.com/elastic/package-registry/blob/1bec8bf2e7f67f04f38a6310f5b70e56e3b22bfd/categories/categories.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@uri-weisman uri-weisman uri-weisman approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

No one assigned

Labels

Integration:aws AWS Integration:azure_metrics Azure Resource Metrics Integration:cloud_asset_inventory Cloud Asset Discovery Integration:cloud_security_posture Security Posture Management Integration:gcp Google Cloud Platform Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trisch-me @andrewkroh @elasticmachine @kaiyan-sheng @uri-weisman @muthu-mps